Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.keys in {{#each}} makes everything borked :) #908

Closed
ispyinternet opened this issue Oct 25, 2017 · 1 comment
Closed

Object.keys in {{#each}} makes everything borked :) #908

ispyinternet opened this issue Oct 25, 2017 · 1 comment

Comments

@ispyinternet
Copy link

Object.keys in {{#each}} makes everything borked

need proof? just click the checkbox in this example: https://svelte.technology/repl?version=1.41.1&gist=13ae9af8f23a6d279350e27bc53a91b9

apparently...

it thinks todos[key].done and todos[key].description depend on both todos and Object (because key depends on Object via Object.keys(...)

who am I to argue!

@Rich-Harris
Copy link
Member

Thanks, this is fixed in 1.42.1. Started out as a relatively simple fix and ballooned into part 1 of a large (and necessary!) refactor — I love it when a subtle bug lights the path to a better way of structuring a codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants