fix: add types for popover attributes and events #10041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 20f9a13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@navorite is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
navorite
changed the title
popover, popovertarget and popovertargetaction attribute typespopover, popovertarget and popovertargetaction attribute types
|
You need to add support for Toggle event too, because right now one provided from svelte differs with typescript one. |
navorite
changed the title
popover, popovertarget and popovertargetaction attribute types
navorite
changed the title
5 tasks
dummdidumm
added a commit
that referenced
this pull request
Jan 2, 2024
#10041 for svelte 4 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10036, this also moves the HTMLDetailsElement
toggleevent to its interface as it was conflicting with HTMLElement popovertoggleevent.Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4and notmain.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint