Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spread attributes reactivity improvements #10071

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jan 3, 2024

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

The objects could contain getters with reactive values, so we play it safe and assume they're always reactive
fixes #10065
Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: 7def574

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 4:33pm

@dummdidumm dummdidumm merged commit 570884e into main Jan 3, 2024
9 checks passed
@dummdidumm dummdidumm deleted the spread-attributes-reactive branch January 3, 2024 16:43
@dummdidumm dummdidumm changed the title fix: treat all spread attributes as reactive fix: spread attributes reactivity improvements Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants