Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: example immutable missing on:click #10079

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

fritx
Copy link
Contributor

@fritx fritx commented Jan 4, 2024

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Fix on:click been accidentally removed (via #8836) from the official example:
https://svelte.dev/examples/immutable-data

Copy link

changeset-bot bot commented Jan 4, 2024

⚠️ No Changeset found

Latest commit: 573bedd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 4, 2024

@fritx is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@dummdidumm dummdidumm changed the base branch from main to svelte-4 January 4, 2024 12:41
@dummdidumm dummdidumm changed the base branch from svelte-4 to main January 4, 2024 12:41
@dummdidumm
Copy link
Member

Thank you! Could you do the same change against the svelte-4 branch, too? That's the one that's currently deploying the svelte.dev site.

@dummdidumm dummdidumm merged commit e9b0908 into sveltejs:main Jan 4, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants