Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loosen input in button error #10083

Merged
merged 4 commits into from
Jan 5, 2024
Merged

fix: loosen input in button error #10083

merged 4 commits into from
Jan 5, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jan 4, 2024

Fixes #10078

Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: 2b3db3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 8:37am

@dominikg
Copy link
Member

dominikg commented Jan 4, 2024

removing input from the list of interactive elements might be too broad?

there is only one special case where it can work and that is <input type="hidden"> inside a button (why you would want it inside the button and not next to it eludes me but here goes)

With this change, input would be allowed to be inside other tags like <a> as well?

@trueadm
Copy link
Contributor Author

trueadm commented Jan 4, 2024

@dominikg It seems the browser doesn't try to patch them. So whilst it's not good for a11y, it's still likely not a compiler error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Using input inside button leads to compile error
3 participants