Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing miter-clip and arcs value to stroke-linejoin attribute #10141

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

lucasile
Copy link
Contributor

'miter-clip' and 'arcs' value for stroke-linejoin attribute is missing in types for SVGAttributes. Adding them here.
Reference: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-linejoin

Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: 32395f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 10, 2024

@lucasile is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 8:59pm

@benmccann
Copy link
Member

Please run pnpm format. The lint CI job is failing

@Rich-Harris Rich-Harris merged commit f7cc8cb into sveltejs:main Jan 26, 2024
6 of 8 checks passed
@Rich-Harris
Copy link
Member

thanks!

trueadm pushed a commit that referenced this pull request Jan 31, 2024
…te (#10141)

* Add missing miter-clip and arcs attribute stroke-linejoin

* format

* changeset

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
dummdidumm pushed a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants