Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure unstate() only deeply applies to plain objects and arrays #10191

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jan 15, 2024

We should really only be calling unstate deeply on plain objects/arrays rather than all objects.

Copy link

changeset-bot bot commented Jan 15, 2024

🦋 Changeset detected

Latest commit: 8804937

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 6:03pm

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes most of #10174 except for the "cannot read cookie" error which seems to be REPL-specific

@trueadm trueadm merged commit 86bbc83 into main Jan 15, 2024
9 checks passed
@trueadm trueadm deleted the unstate-tweaks branch January 15, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants