Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add compiler error for invalid <p> contents #10201

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jan 16, 2024

Fixes #10123

Copy link

changeset-bot bot commented Jan 16, 2024

🦋 Changeset detected

Latest commit: 69ba8ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 4:06pm

@pooledge
Copy link

Hmm it seems this error can be also triggered by perfectly valid HTML now, at least that is what I am seeing using transformPageChunk in hooks.server.ts:

<body data-sveltekit-preload-data="hover">
                <div style="display: contents"><!--[--><!--[--><!--[--><!--[--><div id="test" class="svelte-13c203z">Test</div><!--]--><!--]--><!--]--> <!--[--><!--]!--><!--]-->
                </div>
</body>

<div> is invalid inside <p> was reported 6 times. How to debug?

@trueadm
Copy link
Contributor Author

trueadm commented Apr 15, 2024

@pooledge It's more likely about what your components hydrate into there being invalid.

@pooledge
Copy link

Restarting dev server after updating npm solved this. I am sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: <p><span><div> compiles but doesn't render
2 participants