Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent false positive store error in module script #10291

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

dummdidumm
Copy link
Member

When a variable with the same name was declared in the instance script, the module-no-auto-store-subscription-validation would fail fixes #10285

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

When a variable with the same name was declared in the instance script, the module-no-auto-store-subscription-validation would fail
fixes #10285
Copy link

changeset-bot bot commented Jan 25, 2024

🦋 Changeset detected

Latest commit: 7f28165

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 005ff89 into main Jan 25, 2024
6 of 8 checks passed
@dummdidumm dummdidumm deleted the store-module-script-rune branch January 25, 2024 10:26
trueadm pushed a commit that referenced this pull request Jan 31, 2024
When a variable with the same name was declared in the instance script, the module-no-auto-store-subscription-validation would fail
fixes #10285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use $state inside context="module" functions
1 participant