Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add scrollend event type #10336

Merged
merged 2 commits into from Jan 30, 2024

Conversation

arslanastral
Copy link
Contributor

Added scrollend event type which is useful when you want to fire an event handler after scrolling has finished vs firing continuously while scrolling as scroll does. closes #10258

Ref:
https://developer.mozilla.org/en-US/docs/Web/API/Document/scrollend_event
https://developer.chrome.com/blog/scrollend-a-new-javascript-event
https://caniuse.com/?search=scrollend

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: 1375e9e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit f2c2490 into sveltejs:svelte-4 Jan 30, 2024
7 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants