fix: don't reuse proxies when state symbol refers to stale value #10343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When somebody copies over the state symbol property onto a new object (you can retrieve the symbol by using `Reflect.ownKeys(...)`), it was wrongfully assumed that it always relates to the current value. This PR adds an additional check that this is actually the case. This also adds a dev time warning when an object is frozen but contains a state property, which hints at a bug in user land. fixes #10316
🦋 Changeset detectedLatest commit: afa96a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trueadm
reviewed
Jan 30, 2024
| @@ -68,7 +84,7 @@ export function proxy(value, immutable = true) { | |||
| * @returns {Record<string | symbol, any>} | |||
| */ | |||
| function unwrap(value, already_unwrapped = new Map()) { | |||
| if (typeof value === 'object' && value != null && !is_frozen(value) && STATE_SYMBOL in value) { | |||
| if (typeof value === 'object' && value != null && STATE_SYMBOL in value) { | |||
There was a problem hiding this comment.
Do we really even need a STATE_SYMBOL in the value? Then we can unwrap derived proxied objects too.
trueadm
approved these changes
Jan 30, 2024
Rich-Harris
reviewed
Jan 30, 2024
Rich-Harris
reviewed
Jan 30, 2024
Rich-Harris
reviewed
Jan 30, 2024
Rich-Harris
requested changes
Jan 30, 2024
Rich-Harris
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When somebody copies over the state symbol property onto a new object (you can retrieve the symbol by using
Reflect.ownKeys(...)), it was wrongfully assumed that it always relates to the current value. This PR adds an additional check that this is actually the case.This also adds a dev time warning when an object is frozen but contains a state property, which hints at a bug in user land.
fixes #10316
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint