fix: handle sole empty expression tags #10433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there's only a single expression tag and its value evaluates to the empty string, special handling is needed to create and insert a text node fixes #10426
🦋 Changeset detectedLatest commit: 4ef53cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Feb 9, 2024
| current_hydration_fragment.unshift(text); | ||
| if (first_node) { | ||
| /** @type {DocumentFragment} */ (first_node.parentNode).insertBefore(text, first_node); | ||
| } | ||
| return text; | ||
| } | ||
|
|
||
| if (first_node !== null) { | ||
| if (first_node) { |
There was a problem hiding this comment.
I believe the explicit comparison is deliberate, since it results in more efficient bytecode
Suggested change
| if (first_node) { | |
| if (first_node !== null) { |
There was a problem hiding this comment.
I did change it because the comparison will be wrongfully false when first_node is undefined when the array is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's only a single expression tag and its value evaluates to the empty string, special handling is needed to create and insert a text node
fixes #10426
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint