Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: synchronise element bindings #10512

Merged
merged 4 commits into from
Feb 22, 2024
Merged

fix: synchronise element bindings #10512

merged 4 commits into from
Feb 22, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Feb 17, 2024

#10511

just a failing test for now

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 17, 2024

🦋 Changeset detected

Latest commit: 36af2f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Gave this a go and quickly fell down a rabbit hole of how to solve the bind_this bugs and timing stuff around this. TLDR the current way does not work for arrays, what we need is to have a way to access the previous index to nullify it in case an item moves. Looking into that right now.

@dummdidumm
Copy link
Member

Turned out to be very easy fix once #10598 was implemented. I think we used the animation frame dance previously where the $effect timing was slightly different and not wait on its children before rerunning. With that now everything false into place nicely.

@dummdidumm dummdidumm marked this pull request as ready for review February 22, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants