Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve code generation for bind:this in SSR mode #10524

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Feb 18, 2024

We do the whole $$settled dance in SSR for components with bind:this, quite unnecessarily. Given this input...

<Child bind:this={child} />

...this PR produces much better output:

// old
export default function App($$payload, $$props) {
  $.push(false);

  let $$settled = true;
  let $$inner_payload;

  function $$render_inner($$payload) {
    const anchor = $.create_anchor($$payload);

    $$payload.out += `${anchor}`;

    Foo($$payload, {
      get this() {
        return foo;
      },
      set this($$value) {
        foo = $$value;
        $$settled = false;
      }
    });

    $$payload.out += `${anchor}`;
  };

  do {
    $$settled = true;
    $$inner_payload = $.copy_payload($$payload);
    $$render_inner($$inner_payload);
  } while (!$$settled);

  $.assign_payload($$payload, $$inner_payload);
  $.pop();
}
// new
export default function App($$payload, $$props) {
  $.push(false);

  const anchor = $.create_anchor($$payload);

  $$payload.out += `${anchor}`;
  Foo($$payload, {});
  $$payload.out += `${anchor}`;
  $.pop();
}

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 18, 2024

🦋 Changeset detected

Latest commit: 321db79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 3da6cef into main Feb 18, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the bind-this-server branch February 18, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants