Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visit expression node in directives #10527

Merged
merged 8 commits into from
Feb 18, 2024
Merged

Conversation

navorite
Copy link
Contributor

@navorite navorite commented Feb 18, 2024

In #10481, I didn't visit child nodes, this led to stores inside the expression not being referenced

I've probably added the worst naming that could be ever done for a type, so appreciate any help naming it properly lol

closes #10514

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 18, 2024

🦋 Changeset detected

Latest commit: 14f588f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@navorite navorite changed the title fix: visit child nodes in directives fix: visit expression in directives Feb 18, 2024
@navorite navorite changed the title fix: visit expression in directives fix: visit expression node in directives Feb 18, 2024
@Rich-Harris
Copy link
Member

thank you! i skirted the naming issue

@navorite navorite deleted the fix-action branch February 19, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Svelte action does not work with $store as parameter
2 participants