fix: better interop of $state with actions/$: statements
#10543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure update methods of actions and reactive statements work with fine-grained `$state` by deep-reading them. This is necessary because mutations to `$state` objects don't notify listeners to only the object as a whole, it only notifies the listeners of the property that changed. fixes #10460 fixes simeydotme/svelte-range-slider-pips#130
🦋 Changeset detectedLatest commit: e94df0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Feb 19, 2024
Closed
dummdidumm
commented
Feb 20, 2024
|
|
||
| p = parents['init_update']; | ||
| assert.deepEqual(p.value, { foo: 'kid' }); | ||
| assert.equal(p.updates.length, 2); | ||
|
|
||
| p = parents['init_mutate']; | ||
| assert.deepEqual(p.value, { foo: 'kid' }); | ||
| assert.equal(p.updates.length, 1); | ||
| assert.equal(p.updates.length, 2); |
There was a problem hiding this comment.
This test is from #8992 and was (turns out, wrongfully) changed when moving to proxies in #9826 . This uncovered that using $.proxy inside svelte/legacy could also have caused these kinds of problems this PR fixes in some situations, but it shouldn't matter anymore now that deeply reactive state is properly handled in the places where it matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure update methods of actions and reactive statements work with fine-grained
$stateby deep-reading them. This is necessary because mutations to$stateobjects don't notify listeners to only the object as a whole, it only notifies the listeners of the property that changed.fixes #10460
fixes simeydotme/svelte-range-slider-pips#130
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint