fix: improve handling of unowned derived signals #10565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10549.
This PR introduces write versions to the both types of signal. For source signals we increment this version number every time a new value is written to the signal. For computation signals we only use the write version for unowned signals (signals that aren't owned by an effect). We check the dependencies of an unowned derived to see if a version is higher than that of the unowned derived signal to determine if the derived is dirty or not.