Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove memory leak, make beforeUpdate etc work correctly #10570

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Feb 20, 2024

Fixes #10548. We were pushing signals to an array on the component context so that beforeUpdate/afterUpdate callbacks could observe them, but we were never cleaning this array up.

It turns out we only need to create this array for non-runes components, since beforeUpdate/afterUpdate are forbidden in runes mode. We can therefore do the binding inside mutable_source. We don't need to do any additional cleanup work because the context should be garbage collected when the component is destroyed.

I also realised that in the (vanishingly rare!) case that a runes-mode component is passing proxied state into a non-runes-mode component, which has a beforeUpdate/afterUpdate callback, the callbacks do not run when a property of the proxied state is updated. This is fixed in this PR by using deep_read instead of shallowly reading props.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 20, 2024

🦋 Changeset detected

Latest commit: 9838ddf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 96eae28 into main Feb 20, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the gh-10548 branch February 20, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5 : Memory leak for {#each}
2 participants