Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle member expressions in directives #10576

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

navorite
Copy link
Contributor

@navorite navorite commented Feb 20, 2024

tried some more edge cases as well, this should match svelte 4's behaviour.

honestly, this would have been better if this was done this at the AST level but this isn't needed if stores are gonna be removed/deprecated in svelte 6 ( i believe? ) anyways.

closes #10566

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 20, 2024

🦋 Changeset detected

Latest commit: 72876e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

to be fair it's not just stores, you can also just do use:foo.bar.baz. But I think this solution is Good Enough™ for what it's used for. thanks!

@Rich-Harris Rich-Harris merged commit d6e0fbd into sveltejs:main Feb 20, 2024
6 of 8 checks passed
@navorite navorite deleted the store-fix branch February 20, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: CompileError on use:$store.action
2 participants