Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: bail early when traversing non-state #10654

Merged
merged 1 commit into from
Feb 27, 2024
Merged

perf: bail early when traversing non-state #10654

merged 1 commit into from
Feb 27, 2024

Conversation

dummdidumm
Copy link
Member

We need to use deep_read to traverse all properties of an object inside legacy mode and inside actions, because the input we get could be a state proxy. This proxy will have fine-grained reactivity and therefore only update the signal at the location that got an update. In order to have interop with the coarse-grained "notify me when anything in that object changes" behavior, we need to setup up signals for all of the object's properties before they're potentially mutated.
This has a lot of overhead for large lists, and we can at least diminish in the "no state proxy" case by applying a sensible heuristic:

  • If the value passed is a state proxy, read it
  • If not, and if the value is an array, then bail because an array of state proxies is highly unlikely
  • Traverse the first level of properties of the object and look if these are state, if not bail. State proxies nested further down are highly unlikely, too

part of #10637

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 27, 2024

🦋 Changeset detected

Latest commit: 1e59989

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…side legacy mode and inside actions, because the input we get could be a state proxy. This proxy will have fine-grained reactivity and therefore only update the signal at the location that got an update. In order to have interop with the coarse-grained "notify me when _anything_ in that object changes" behavior, we need to setup up signals for all of the object's properties before they're potentially mutated.

This has a lot of overhead for large lists, and we can at least diminish in the "no state proxy" case by applying a sensible heuristic:
- If the value passed is a state proxy, read it
- If not, and if the value is an array, then bail because an array of state proxies is highly unlikely
- Traverse the first level of properties of the object and look if these are state, if not bail. State proxies nested further down are highly unlikely, too

part of #10637
@dummdidumm dummdidumm merged commit 3fe4940 into main Feb 27, 2024
8 checks passed
@dummdidumm dummdidumm deleted the deep-read-perf branch February 27, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants