Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better ownership mutation validation #10673

Merged
merged 5 commits into from
Mar 1, 2024
Merged

fix: better ownership mutation validation #10673

merged 5 commits into from
Mar 1, 2024

Conversation

dummdidumm
Copy link
Member

Fixes #10649

  • widen ownership when getContext/getAllContexts is called
  • widen ownership when assigning one proxy to another
  • skip first 4 stack trace entries and bail if first after that is not a module, hinting at a mutation encapsulated in a .svelte.js file

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: 0c781e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented Mar 1, 2024

LGTM!

@dummdidumm dummdidumm merged commit 5768ac3 into main Mar 1, 2024
8 checks passed
@dummdidumm dummdidumm deleted the ownership-fixes branch March 1, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte5: Potential Ownership False Positive 'mutated a value owned...This is strongly discouraged...'
2 participants