Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't collapse whitespace within text nodes #10691

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

dummdidumm
Copy link
Member

fixes #9892 - whitespace at the edges of text is trimmed as before, but whitespace within text nodes is kept as-is under the assumption that someone has put the whitespace there on purpose.

We still need to decide whether or not we actually want to do this (I'm in favor) - this PR shows that it's possible to do without adjustments anywhere else in the compiler (no difference in walking nodes etc)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 4, 2024

🦋 Changeset detected

Latest commit: 4716468

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

seems reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Snippets and slots remove whitespace
2 participants