Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalidate store when mutated inside each block #10785

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

dummdidumm
Copy link
Member

fixes #10771

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: 21e52a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

This works for {#each $checks as checked}, but not {#each identity($checks) as checked}. Then again, that also doesn't work in Svelte 4. Do we care?

@dummdidumm
Copy link
Member Author

Should've added a comment to the code - I noticed quite soon that anything else than a plain $store access in the array doesn't work in Svelte 4, so I vote "good enough".

@Rich-Harris Rich-Harris merged commit fbbd89a into main Mar 13, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the store-each-invalidate branch March 13, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: derived store not reactively updated
2 participants