fix: improve element class attribute behaviour #10856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4079edd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
reviewed
Mar 21, 2024
| * @param {string} value | ||
| * @returns {void} | ||
| */ | ||
| export function svg_class_name(dom, value) { |
There was a problem hiding this comment.
I think it makes sense to code-golf this: add a boolean which is true by default, and when true it uses the regular dom element variant, else the "always attribute" variant.
There was a problem hiding this comment.
Not sure I follow? We can't use the class_name variant at all here as it does set_class_name.
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
dom.classNameas a string, when it's really an object in the form ofSVGAnimatedString. Instead we use a dedicated SVG class name path that is better optimized for this case.classif the value is nullish then we remove the attribute, otherwise we keep it and make it empty. This seems to have a big performance impact, where removing the attribute is causing additional reflows vs just changing it to an empty string.