Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add elementtiming HTMLAttribute, remove crossorigin from HTMLInputAttributes #10921

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

miunau
Copy link
Contributor

@miunau miunau commented Mar 25, 2024

elementtiming is valid for all elements with a background-image so basically everything, which is why I've added it to HTMLAttributes.

See: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/elementtiming

crossorigin is not a valid attribute for input elements:

valid on the <audio>, <img>, <link>, <script>, and <video> elements

See: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/crossorigin

The current implementation for allowing it in every SVG element is a little footgun-y, as you can't use it with the use element inside a SVG, just the script and image ones, but I felt it was outside of the scope of this PR. I instead started issue #10924.

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 19fd80e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants