fix: further improvements to effect scheduling and flushing #10971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a7981b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
reviewed
Mar 28, 2024
Rich-Harris
reviewed
Mar 28, 2024
Rich-Harris
reviewed
Mar 28, 2024
Rich-Harris
reviewed
Mar 28, 2024
Rich-Harris
reviewed
Mar 28, 2024
| is_flushing_effect = true; | ||
|
|
||
| try { | ||
| // When working with custom elements, the root effects might not have a root |
There was a problem hiding this comment.
what does 'the root effects might not have a root' mean?
There was a problem hiding this comment.
This was prior to this PR. The render effect is custom element logic has no root
Rich-Harris
reviewed
Mar 28, 2024
Rich-Harris
approved these changes
Mar 28, 2024
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10946
This a follow up to 10949. Now we have true topological ordering of effects, it makes sense to try and improve certain parts of the processing of the nested effects.
Whilst looking into the bug referenced above, I noticed that we traverse into inert/destroyed effect trees, which is just pointless. I also noticed that maybe after the refactors in this PR, maybe we could just invoke render effects directly. Everything passes but one e2e test to do with custom elements. So maybe this is promising!
I also noticed that flushing of local render effects wasn't correctly setting the counter back to zero like we do in other places – which is another reported issue when using legacy effects with
beforeUpdate, as that triggers this code path. I added a test to capture that not failing.