chore: compiler subpackage #10988
Merged
chore: compiler subpackage #10988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c77ba9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Pretty sure this will break language tools - @jasonlyu123 could you check and if it does break create a PR that can deal with the new structure? |
dummdidumm
added a commit
to sveltejs/language-tools
that referenced
this pull request
Apr 1, 2024
dummdidumm
added a commit
to sveltejs/language-tools
that referenced
this pull request
Apr 1, 2024
|
Released new versions of language tools which can deal with the subpackage, so this can be merged whenever. |
|
svelte vs code is crashing, can't find complier.cjs and eslint is not liking require in index.js file as it should be module according to eslint expectations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
compiler.cjstocompiler/index.js, per a previous decision. I had hoped to useimportScriptinside the REPL workers, but alas we can't do that because they're module workers (but only during development IIUC?) and I couldn't be bothered to fight with it