Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent unparenthesized sequence expressions in attributes #11032

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Rich-Harris
Copy link
Member

We'd like to reserve the possibility of doing something with sequence expressions in attributes in future, and this requires us to treat them as disallowed in the meantime. They still work but they need to be wrapped in parens.

Question: should this apply universally, or just in runes mode?

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: e9567e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Just in runes mode because who knows who depends on that in old code

@Rich-Harris Rich-Harris merged commit 9290983 into main Apr 2, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the prevent-sequence-expression branch April 2, 2024 18:47
@brunnerh
Copy link
Member

brunnerh commented Apr 3, 2024

Getting an error on this 🤔

<svelte:options runes />
<input value={(1, 2)} />

REPL

Works for components:

<svelte:options runes />
<script>
	import Child from './Child.svelte';
</script>
<Child value={(1, 2)} />
<Child value={1, 2} />

REPL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants