Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update error message for snippet binding and assignments #11168

Merged
merged 5 commits into from
Apr 14, 2024

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Apr 14, 2024

Currently, binding and assignments in runes mode for snippet function arguments mentions about the each block.

Created another type of binding kind to differentiate between each and snippet.

Fixes #11084

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@tanhauhau tanhauhau force-pushed the tanlh/feat/better-snippet-error branch from 9674278 to 38cabff Compare April 14, 2024 13:03
Copy link

changeset-bot bot commented Apr 14, 2024

🦋 Changeset detected

Latest commit: 93010ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

changeset-bot bot commented Apr 14, 2024

🦋 Changeset detected

Latest commit: 38cabff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit a092899 into sveltejs:main Apr 14, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Misleading error message "Cannot reassign or bind to each block argument in runes mode."
2 participants