Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add warning when using $bindable runes without calling it #11181

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

tanhauhau
Copy link
Member

Fixes #11173

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: c67fb68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti
Copy link
Member

I kinda started working on this and then surrendered because i was trying to fix the same problem for all the runes. @tanhauhau do you think it could be worth making a more generic check and make the compilre warn if you are using but not calling a rune?

@trueadm trueadm merged commit 1510c13 into sveltejs:main Apr 17, 2024
7 of 8 checks passed
@tanhauhau tanhauhau deleted the tanhauhau/feat/bindable-warning branch April 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: The $bindable rune is only available inside .svelte and .svelte.js/ts files
3 participants