Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couple of small follow-ups to #11197:
push_template_node
,effect
is almost always thecurrent_effect
. we can use a default value and make the callsites more conciseif (current_dom[0].nodeType === 8)
stuff makes me very nervous. feels like the sort of thing that could break easily, e.g. ifpreserveComments
was enabled. I've felt for a while that we should probably just have a field onEachItem
containing the opening anchor. This PR adds one. It means that an additional empty text node is created per each item (except during hydration, when the existing comments can be used), but it feels a bit more robust to me and avoids all theget_first_child
calls