Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize object property mutations in compilation #11243

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

caiquetorres
Copy link
Contributor

Currently, when compiling Svelte code containing object property mutations such as object.count++, the Svelte compiler generates verbose JavaScript output involving a closure and unnecessary variable assignment, as demonstrated in the example provided. This PR addresses this inefficiency by optimizing the generated JavaScript output for object property mutations.

During my investigation, I observed that earlier versions of Svelte utilized the mutate function for updating values, which returned the value after modification. Consequently, logic akin to the current compiler-generated output was implemented. However, with the new Svelte version, this output is unnecessary, as simple expressions like object.count++ or object.count += 1 suffice.

The proposed solution involves enhancing the compiler to detect object property mutations and generate streamlined JavaScript output directly corresponding to the intended operation, without the need for additional closures or variable assignments. To achieve this, the compiler now checks the context when converting the code, specifically for the usage of runes.

Closes #10546

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 2029219

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit f632b2a into sveltejs:main Apr 19, 2024
6 of 8 checks passed
@Rich-Harris
Copy link
Member

thank you!

@caiquetorres caiquetorres deleted the optimize-object-mutations branch April 20, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte 5: unnecessary code generated for updates
2 participants