Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add read-only binding focused #11271

Merged

Conversation

RaiVaibhav
Copy link
Contributor

@RaiVaibhav RaiVaibhav commented Apr 21, 2024

Svelte 5 rewrite

Add new readonly focused binding
Feat: #8949

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 21, 2024

🦋 Changeset detected

Latest commit: bb4c3e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RaiVaibhav RaiVaibhav force-pushed the feat/add-support-for-bind-focused branch from e753782 to e73b9ae Compare April 21, 2024 07:50
@RaiVaibhav RaiVaibhav force-pushed the feat/add-support-for-bind-focused branch from 352e861 to 1770dc9 Compare April 21, 2024 08:01
@RaiVaibhav
Copy link
Contributor Author

Forgot to run the lint before push, I have forced pushed the changes into one commit.

@RaiVaibhav
Copy link
Contributor Author

Hey @trueadm can you help me with failing lint, not sure what's the issue, here with CI.

@RaiVaibhav
Copy link
Contributor Author

🤯 entire code just changed with flush and listen, feels like I did a lot of mistakes, a lot 😅

@Rich-Harris Rich-Harris merged commit 11c7cd5 into sveltejs:main Apr 22, 2024
6 of 8 checks passed
@Rich-Harris
Copy link
Member

thank you! starting the PR is the hard part, the rest is just minor details :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants