Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve type definition error in svelte/compiler #11283

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented Apr 21, 2024

closes: #11282.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 21, 2024

🦋 Changeset detected

Latest commit: 53bc49b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

Weird. I don't really see why this change should make a difference. Do you know whether the important part was the change to the compiler/index.js file or the change to the types file?

@baseballyama
Copy link
Member Author

baseballyama commented Apr 21, 2024

The direct cause is packages/svelte/types/index.d.ts. Remove export { walk }; by hand and everything works properly.
However, since this file is auto-generated by dts-buddy, so we need to modify source file packages/svelte/src/compiler/index.js.

It seems to be essentially a TypeScript issue, but I am not sure.

@Rich-Harris Rich-Harris merged commit 0bb49b1 into main Apr 22, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the fix/types branch April 22, 2024 12:22
@Rich-Harris
Copy link
Member

Definitely weird, but the fix seems harmless enough — thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte5: 5.0.0-next.102 breaks svelte/compiler types
3 participants