-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backwards compat for dash-case warnings #11495
Conversation
Compiler warnings that are dashed are also taken into account for ignoring warnings for backwards compatiblity (else many apps would be littered with a11y warnings now). Also adds logic to the migration script to convert these to underscores.
🦋 Changeset detectedLatest commit: 546cc7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think we should probably try and remap the warnings that have changed beyond just I also think we should only do this in non-runes mode. In runes mode we should warn on any unknown codes. |
…lso adjusted the approach to ignores.
|
"column": 29, | ||
"line": 5 | ||
}, | ||
"message": "`<img>` element should have an alt attribute (this warning was tried to silence using code a11y-missing-attribute. In runes mode, use the new code a11y_missing_attribute instead)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be simpler and more helpful to warn on <!-- svelte-ignore a11y-missing-attribute -->
in runes mode, and leave the other warning untouched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(working on this)
sites/svelte-5-preview/src/routes/docs/content/03-appendix/02-breaking-changes.md
Outdated
Show resolved
Hide resolved
Closing in favor of the other PRs that did this. |
Compiler warnings that are dashed are also taken into account for ignoring warnings for backwards compatiblity (else many apps would be littered with a11y warnings now).
Also adds logic to the migration script to convert these to underscores.
Along the way I discovered that attribute a11y warnings were unsilenceable, the path upwards traversal was more robust in that regard.
Related to #11414
fixes #11482
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint