Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure derived is detected as dirty correctly #11496

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: ensure derived is detected as dirty correctly #11496

merged 1 commit into from
May 7, 2024

Commits on May 7, 2024

  1. fix: ensure derived is detected as dirty correctly 

    Deriveds where under certain conditions not detected as dirty correctly. The reason is that a transitive check_dirtiness call could update the flag of a derived, even if the condition doesn't ulimately result to true. That's why the check for "is now dirty" needs to be moved out of the inner if block.
Fixes #11481

This may also fix a yet undetected overfiring bug in the "is unowned" case because the previous inner "is now dirty?" check didn't take unowned into account.
    @dummdidumm
    dummdidumm committed May 7, 2024
    Configuration menu
    Copy the full SHA
    fc43cff View commit details
    Browse the repository at this point in the history