Verify computed property dependencies #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the validator to fail if someone forgets to declare
dependent properties for computed state:
```
export default {
computed: {
bar: () => { return new Date().getTime(); }
}
};
```
Current coverage is 90.88% (diff: 100%)@@ master #115 diff @@
==========================================
Files 48 48
Lines 1324 1328 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1203 1207 +4
Misses 121 121
Partials 0 0
|
|
This is a nice touch, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the PR merged this code snipped will fail to compile:
Helps newbies to properly use computed properties and verifies the compiler does not generate broken code (would generate
if ( )somewhere in the code base otherwise.