escape attribute values in SSR #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 126 126
Lines 4524 4524
Branches 1461 1461
=======================================
Hits 4139 4139
Misses 163 163
Partials 222 222
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this up instead of #1142. (Thanks @tav!) I'm fairly certain that all we need to escape are the same things that
__escapealready escapes. In particular, we do not need to worry about the IE behavior where attribute values can be enclosed in backticks because we are already going to be enclosing everything in double quotes - so the browser will see that first, before any potential backtick.