Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip deriveds for props with known safe calls #11595

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

Very small thing but I noticed while working on #11571 and #11574 that we treat certain function calls as 'safe' for the purposes of determining whether to wrap props in deriveds, but we only use that information for spread attributes, because we put the parentheses in the wrong place.

No test because it's finicky and extremely minor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 0eea150

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit b212b17 into main May 13, 2024
2 of 8 checks passed
@Rich-Harris Rich-Harris deleted the safe-calls branch May 13, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants