Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error on imports to svelte/internal/* #11632

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

dummdidumm
Copy link
Member

closes #11622

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: d2ed623

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Should we also error on svelte/internal (without the trailing /*) in runes mode? That way we can (eventually) provide back-compat on a best-effort basis while setting ourselves up to banish it altogether in Svelte 6

@Rich-Harris Rich-Harris merged commit 4bedd0e into main May 15, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the error-import-internal branch May 15, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Throw an error when importing svelte/internal/*
2 participants