fix: avoid state_referenced_locally warning within type annotations

[trueadm]

Fixes #11614

[changeset-bot]

🦋 Changeset detected

Latest commit: 3935277

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
svelte	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Rich-Harris]

this feels wrong, pretty sure we should be bailing in is_reference so that this isn't treated as a reference in the first place? this is like obj = { count: 42 } treating count as a reference

[Rich-Harris]

A wrinkle here is that is_reference is an external module that really shouldn't be TS-aware. Ideally, we'd solve this by not visiting children of TSWhatever nodes, but that doesn't work with our visitor merging logic.

Conclusion: we should retire the visitor merging logic instead of having single cross-functional visitors. I've been meaning to work on that for a while anyway. It'll be a bit noisy though so we should probably try and close as much of the PR queue as possible first

[Rich-Harris]

marking as draft until we can take that on, to reduce noise

[trueadm]

@Rich-Harris I first started off be pulling out is_reference and changing it to work like you mentioned, but then I realised that this probably was just an issue with this particular warning.

[dummdidumm]

We're supposed to strip all TS traces at https://github.com/sveltejs/svelte/blob/main/packages/svelte/src/compiler/index.js#L37 - wonder why it doesn't work for this? The real fix probably lies in there.

[trueadm]

We're supposed to strip all TS traces at https://github.com/sveltejs/svelte/blob/main/packages/svelte/src/compiler/index.js#L37 - wonder why it doesn't work for this? The real fix probably lies in there.

Seems to be missing TSTypeAnnotation and a bunch of others.

[trueadm]

I applied a better fix, thanks @dummdidumm