Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consistent nextSibling usage #11694

Merged
merged 2 commits into from
May 20, 2024
Merged

chore: consistent nextSibling usage #11694

merged 2 commits into from
May 20, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented May 20, 2024

We should avoid doing node.nextSibling and instead use the next_sibling(node) function which is slightly faster and avoids deopts.

Copy link

changeset-bot bot commented May 20, 2024

⚠️ No Changeset found

Latest commit: 4f50b74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit f3dbfc9 into main May 20, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the consistent-next-sibling branch May 20, 2024 16:07
@Rich-Harris
Copy link
Member

Actually I tested this locally and it made things slower for me. Going to revert it

Rich-Harris added a commit that referenced this pull request May 20, 2024
Rich-Harris added a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants