Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use console.trace inside dev warnings #11744

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

While working on the playground console stuff I realised that we're currently doing console.trace after printing warnings in dev mode. This is because I'm a Firefox user, and Firefox doesn't include traces in warnings.

Chrome does. Since the vast majority of developers use Chrome for developing, this means unnecessary clutter. We could get fancy and detect which browser we're in but I think it's overkill.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 23, 2024

🦋 Changeset detected

Latest commit: 35113d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit ba429fd into main May 23, 2024
8 checks passed
@dummdidumm dummdidumm deleted the remove-console-trace branch May 23, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants