Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow runelike writable as prop #11768

Merged

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

Closes #11742

I had to guard against props being the store name because a situation like this doesn't make sense

<script>
    let { props } = $props();
</script>

{$props}

because disabling props as a rune in favor of a prop being a store would mean you cannot access the writable in the first place (kinda convoluted i know). Should we throw a more descriptive error in that case?

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 24, 2024

🦋 Changeset detected

Latest commit: e8e4290

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could adjust the error message, but I think that case is so rare we don't need to worry about it

@dummdidumm dummdidumm merged commit 9084f17 into sveltejs:main May 24, 2024
7 of 8 checks passed
@paoloricciuti
Copy link
Member Author

We could adjust the error message, but I think that case is so rare we don't need to worry about it

New Issue: confusing error when passing a store that is named props to component 😄 😄 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing a Writable as prop to a component doesn't allow "$" access
2 participants