Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capturing the correct event names in set_attributes #11783

Merged
merged 8 commits into from
May 27, 2024

Conversation

FoHoOV
Copy link
Contributor

@FoHoOV FoHoOV commented May 25, 2024

in attributes.js we we are capturing the wrong key for events.

() => (next[key] = create_event(event_name, element, value, opts))

since the lifespan of key outlasts each iteration of that loop, it will point to the last value it was assigned when the callback function is called. so, if the list had multiple values, we always get the last value in that list.

fixes #11777

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 25, 2024

🦋 Changeset detected

Latest commit: 88fb268

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FoHoOV FoHoOV marked this pull request as ready for review May 25, 2024 21:42
@FoHoOV FoHoOV marked this pull request as draft May 25, 2024 21:45
@FoHoOV FoHoOV marked this pull request as ready for review May 25, 2024 22:06
@FoHoOV FoHoOV changed the title fix: using the correct event names in set_attributes fix: capturing the correct event names in set_attributes May 25, 2024
@FoHoOV FoHoOV requested a review from dummdidumm May 26, 2024 14:48
@FoHoOV FoHoOV marked this pull request as draft May 27, 2024 03:04
@FoHoOV FoHoOV marked this pull request as ready for review May 27, 2024 03:07
@dummdidumm dummdidumm merged commit 4fef0eb into sveltejs:main May 27, 2024
6 of 8 checks passed
@FoHoOV FoHoOV deleted the fix-set-attributes branch May 27, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: onanimationend event doesn't get called under these specific circumstances.
2 participants