Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse ongotpointercapture and onlostpointercapture events correctly #11790

Merged
merged 4 commits into from
May 27, 2024

Conversation

FoHoOV
Copy link
Contributor

@FoHoOV FoHoOV commented May 26, 2024

There are some instances in the code where we remove the on prefix from the event names but still compare them against ongotpointercapture and onlostpointercapture with the on prefix.

Fixes #11789.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 26, 2024

🦋 Changeset detected

Latest commit: cb6d1e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FoHoOV FoHoOV changed the title fix: parse none captured events ending with captured name correctly fix: parse ongotpointercapture and onlostpointercapture events correctly May 26, 2024
@FoHoOV FoHoOV marked this pull request as ready for review May 26, 2024 15:05
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit b963e53 into sveltejs:main May 27, 2024
6 of 8 checks passed
@FoHoOV FoHoOV deleted the fix-captured-event-parsing branch May 27, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte 5: gotpointercapture and lostpointercapture not paresed correctly
2 participants