fix: ensure visit is called with correct state #11798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our
visit
calls have the wrong current state associated with it. To fix it, we need to pass the real current one. fixes #11722While doing so I discovered that we're not updating the scope correctly in some places - right now it more or less works by accident because in the scope analysis phase we're creating the scope on the parent, not the fragment in a lot of cases (but not all, which is why it had to be adjusted in some places). This is brittle so I adjusted the logic to be more robust (this will likely save us some trouble when we eventually remove the slot scoping logic).
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint