Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure visit is called with correct state #11798

Merged
merged 3 commits into from
May 28, 2024
Merged

fix: ensure visit is called with correct state #11798

merged 3 commits into from
May 28, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented May 27, 2024

Some of our visit calls have the wrong current state associated with it. To fix it, we need to pass the real current one. fixes #11722

While doing so I discovered that we're not updating the scope correctly in some places - right now it more or less works by accident because in the scope analysis phase we're creating the scope on the parent, not the fragment in a lot of cases (but not all, which is why it had to be adjusted in some places). This is brittle so I adjusted the logic to be more robust (this will likely save us some trouble when we eventually remove the slot scoping logic).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Some of our `visit` calls have the wrong current state associated with it. To fix it, we need to pass the real current one.
fixes #11722
Copy link

changeset-bot bot commented May 27, 2024

🦋 Changeset detected

Latest commit: 6068ba0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 538060e into main May 28, 2024
8 checks passed
@dummdidumm dummdidumm deleted the scope-fixes branch May 28, 2024 15:58
@dummdidumm dummdidumm mentioned this pull request Jun 6, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Bug with data exposed to a slot in a slot
2 participants