Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: robustify initial scroll value detection when scroll is smooth #11802

Merged
merged 1 commit into from
May 28, 2024

Conversation

dummdidumm
Copy link
Member

  • the previous assumption was wrong: browser don't fire a scroll event initially when the scroll isn't smooth
  • the previous logic wasn't using the "is scrolling now" logic which meant the render effect fired immediately after, causing smooth scrolling to start too late to be overridden

adjusted the comment and reused the scroll handler function to guard against the race condition
fixes #11623

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

- the previous assumption was wrong: browser don't fire a scroll event initially when the scroll isn't smooth
- the previous logic wasn't using the "is scrolling now" logic which meant the render effect fired immediately after, causing smooth scrolling to start too late to be overridden

adjusted the comment and reused the scroll handler function to guard against the race condition
fixes #11623
Copy link

changeset-bot bot commented May 28, 2024

🦋 Changeset detected

Latest commit: 54ffef5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm trueadm merged commit ba6697d into main May 28, 2024
8 checks passed
@trueadm trueadm deleted the scroll-binding-fix branch May 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binding scrollY to svelte:window causes implicit scrolling to the top of the page
2 participants