Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increment version when creating new source in Map.get or Map.has #11913

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

Closes #11909

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: 017b57b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti paoloricciuti changed the title fix: increment version when creating new source in get or has fix: increment version when creating new source in Map.get or Map.has Jun 5, 2024
@dummdidumm dummdidumm merged commit 862949d into sveltejs:main Jun 5, 2024
6 of 8 checks passed
@Rich-Harris
Copy link
Member

This doesn't really feel like the right solution to me. The reason the test fails without this change seems to be because there's no source initially created by the time #read_all is called — surely we should be populating this.#sources in the constructor?

@paoloricciuti
Copy link
Member Author

This doesn't really feel like the right solution to me. The reason the test fails without this change seems to be because there's no source initially created by the time #read_all is called — surely we should be populating this.#sources in the constructor?

I might be wrong but i think @trueadm specifically created the sources lazily...that's why i went with this solution.

@Rich-Harris
Copy link
Member

We can populate it lazily in #read_all but we definitely don't want to invalidate the entire thing on every get or has, that's very expensive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5 reactive map updates values given in constructor only after other data is updated
3 participants