Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly backport svelte:element to old AST #11917

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

dummdidumm
Copy link
Member

Both <svelte:element this="div"> and <svelte:element this={"div"}> were backported as tag: "div" for the old AST. That's wrong because the latter should result in tag: { type: 'Literal', .. }. Fixing this makes all the tests in prettier-plugin-svelte pass with Svelte 5.

Also cleaned up a bit of code in the parser.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Both `<svelte:element this="div">` and `<svelte:element this={"div"}>` were backported as `tag: "div"` for the old AST. That's wrong because the latter should result in `tag: { type: 'Literal', .. }`. Fixing this makes all the tests in prettier-plugin-svelte pass with Svelte 5.

Also cleaned up a bit of code in the parser.
Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: e7831e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 6efd9d6 into main Jun 5, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the fix-svelte-element-legacy-ast branch June 5, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants